search

adur1990 / Pass-for-macOS

macOS wrapper for pass, the standard UNIX password manager
BSD 3-Clause "New" or "Revised" License
111 stars 8 forks source link

Blue icon text in Safari 14 #36

Closed rnkn closed 4 years ago

rnkn commented 4 years ago

Describe the bug

Hi. I just "upgraded" to Safari 14 and found that the Pass button text is now incongruously blue.

To Reproduce

  1. Begrudgingly upgrade to Safari 14.
  2. Open a Safari window with the Pass button in the Toolbar.
  3. The Pass button has blue text.

Expected behavior

I think the Pass button is supposed to have black text.

Screenshots

Screen Shot 2020-09-17 at 5 47 34 pm Screen Shot 2020-09-17 at 5 49 25 pm

Desktop (please complete the following information)

Additional information

Thanks for doing a great job! :)

adur1990 commented 4 years ago

Hi,

thanks for pointing this out, but unfortunately this is no bug, this is intended behavior in Safari 14.

In summary, Apple highlights extensions that currently have access to the page this way. It's annoying, but this is how it is. Theoretically I could avoid this by providing an icon for the "active" state, but this would defy the purpose of informing the user which extensions are currently accessing the page.

Interestingly, Apple itself does not comply with this rule, as the privacy report does not turn blue.

rnkn commented 4 years ago

I wonder if there is anyone in the world who sees this and thinks "oh thanks Apple, that's certainly 100% clear and not a bug at all."

Thanks for looking into this :)