search

advanced-cms / advanced-reviews

This is an Open Source add-on that improves the reviewing process and lets external users to view & review content items or whole projects without the need to access the Edit Mode. Created and maintained by Bartosz Sekuła and Grzegorz Wiecheć
Apache License 2.0
17 stars 15 forks source link

Error while trying to edit in the External Review Content Url #161

Closed santiagomorlaverndale closed 4 years ago

santiagomorlaverndale commented 4 years ago

I have shared an edit url so an external reviewer can check a page: https://mydomain/externalContentReviews/818e52c0-2bd5-48f0-bf8a-4aafad8a193e but it's failing. Once I try to add a comment, it throws this error:

react-dom.production.min.js:193 TypeError: Cannot read property 'allowScreenshotAttachments' of undefined
    at t.render (new-review-dialog.tsx:88)
    at ke (mobx.module.js:991)
    at mobx-react.module.js:1
    at _e (mobx.module.js:779)
    at e.track (mobx.module.js:1806)
    at t.c [as render] (mobx-react.module.js:1)
    at t.<anonymous> (mobx-react.module.js:1)
    at t.render (mobx-react.module.js:1)
    at Ma (react-dom.production.min.js:178)
    at ka (react-dom.production.min.js:177)
es @ react-dom.production.min.js:193
As.n.callback @ react-dom.production.min.js:207
mi @ react-dom.production.min.js:130
hi @ react-dom.production.min.js:130
Ec @ react-dom.production.min.js:250
t.unstable_runWithPriority @ scheduler.production.min.js:18
Ko @ react-dom.production.min.js:119
Cc @ react-dom.production.min.js:242
sc @ react-dom.production.min.js:220
(anonymous) @ react-dom.production.min.js:120
t.unstable_runWithPriority @ scheduler.production.min.js:18
Ko @ react-dom.production.min.js:119
Go @ react-dom.production.min.js:120
Xo @ react-dom.production.min.js:119
nc @ react-dom.production.min.js:211
enqueueSetState @ react-dom.production.min.js:132
_.setState @ react.production.min.js:13
reviewLocationCreated @ iframe-with-pins.tsx:115
t.addReviewLocation @ iframe-overlay.tsx:152
new-review-dialog.tsx:88 Uncaught TypeError: Cannot read property 'allowScreenshotAttachments' of undefined
    at t.render (new-review-dialog.tsx:88)
    at ke (mobx.module.js:991)
    at mobx-react.module.js:1
    at _e (mobx.module.js:779)
    at e.track (mobx.module.js:1806)
    at t.c [as render] (mobx-react.module.js:1)
    at t.<anonymous> (mobx-react.module.js:1)
    at t.render (mobx-react.module.js:1)
    at Ma (react-dom.production.min.js:178)
    at ka (react-dom.production.min.js:177)

Could you help me with this?

daniel-isaacs commented 4 years ago

@santiagomorlaverndale Just wondering, is your site multi-language? I've got this same error on a multi-language site, but it's working on a single-language site. Curious if that could be related.

santiagomorlaverndale commented 4 years ago

@daniel-isaacs No, my site is just an US-English site. I had to revert to version 0.7.3 instead of 0.7.4 to make it work.

barteksekula commented 4 years ago

Fixed in https://nuget.episerver.com/package/?id=Advanced.CMS.AdvancedReviews&v=0.7.5