search

advanced-cms / advanced-reviews

This is an Open Source add-on that improves the reviewing process and lets external users to view & review content items or whole projects without the need to access the Edit Mode. Created and maintained by Bartosz Sekuła and Grzegorz Wiecheć
Apache License 2.0
17 stars 15 forks source link

Unable to view external review link #203

Closed JamesOlano closed 2 years ago

JamesOlano commented 2 years ago

Hi,

We installed the Advanced Reviews package from NuGet Package Manager on Visual studio to our solution. We tried to add an external review link while the changes on the page is not yet published. After opening the link, it now displays the error on the 2nd picture. The behavior is that “?preview_generated=True” is continuously appended on the URL.

epi-1 site-1 site-2

Are we missing out on something? Kindly help us on this issue we are encountering.

Thanks!

James

barteksekula commented 2 years ago

I assume you added a link having a project selected right? Does it work outside of project context?

barteksekula commented 2 years ago

The only place we append preview_generated query param is our custom UrlResolver. Do you happen to have your own UrlResolver? Any custom implementations of built-in epi classes? I've just checked on a clean Alloy and everything seems to work fine. It would be great if you tried to reproduce on clean Alloy with your custom code applied. That would be a huge help

JamesOlano commented 2 years ago

I assume you added a link having a project selected right? Does it work outside of project context?

We tried to moved it outside of project context and the external review link returned 404 page if the page is not yet published. For those published pages that have drafted changes, it does not display the updated changes.

barteksekula commented 2 years ago

This project is successfully used in numerous sites so there must be something specific to your site, some customization like custom UrlResolver or ContentAreaLoader or sth like that. Could you try to reproduce in Alloy? It's very easy, just clone this repo and start the project. Then you could try to add your customizations one by one to find which one is causing this.

barteksekula commented 2 years ago

@JamesOlano any updates?