search

advanced-cms / advanced-reviews

This is an Open Source add-on that improves the reviewing process and lets external users to view & review content items or whole projects without the need to access the Edit Mode. Created and maintained by Bartosz Sekuła and Grzegorz Wiecheć
Apache License 2.0
17 stars 15 forks source link

Null reference exception while fallback to master language #234

Closed solita-kpetrov closed 1 year ago

solita-kpetrov commented 1 year ago

Hi!

https://github.com/advanced-cms/advanced-reviews/commit/5600cdce6535bdcc6d443cab0177ac0b719d8add in these changes var contentRouteData = _defaultUrlResolver.Route(urlBuilder, routeArguments); seems returns null in some cases (at least we are having this issue in last update) Shouldn't be there an additional null check?

We are not able to apply this update that contains an urgent fix https://github.com/advanced-cms/advanced-reviews/commit/b14ceb3fca0c1de268bdd55212798b3408002446

barteksekula commented 1 year ago

Of course, you are right.

barteksekula commented 1 year ago

1.3.5 will be available soon