Generated image url is invalid

advanced-cms / advanced-reviews

This is an Open Source add-on that improves the reviewing process and lets external users to view & review content items or whole projects without the need to access the Edit Mode. Created and maintained by Bartosz Sekuła and Grzegorz Wiecheć

Apache License 2.0

17 stars 15 forks source link

Generated image url is invalid #240

Closed KongKvistad closed 1 year ago

KongKvistad commented 1 year ago

When creating an external review link, every image on said page will generate a link through imageProxy, E.G:

https://localhost:44390/ImageProxy?token=d099f130-79ad-4343-ad72-346d5dcd1b1a&contentLink=90443_878742?transform=DownFit&width=700&hash=ab0e358e1d29067d8539a4841c61ab17

Removing the portion after the last question mark provides a valid link, so maybe there is an issue with concatenating two question marks?

barteksekula commented 1 year ago

@KongKvistad who adds the second question mark? This is the image proxy generator: https://github.com/advanced-cms/advanced-reviews/blob/master/src/Advanced.CMS.ExternalReviews/ExternalReviewUrlGenerator.cs#L23