TreSmith
commented
2 weeks ago This chunk of code here in GetChildrenWithReviews() line 80-84
var referenceWithoutVersion = contentLink.ToReferenceWithoutVersion();
if (referenceWithoutVersion == ContentReference.WasteBasket)
{
return _contentLoader.GetChildren<T>(contentLink);
}calls .GetChildren(contentLink) when the ContentReference is a reference to the WasteBasket The GetChildren that is called is the override version found in the DraftContentLoader.cs file line 57
This chunk of code ends up looping until the server crashes
public override IEnumerable<T> GetChildren<T>(ContentReference contentLink)
{
if (!_externalReviewState.IsInExternalReviewContext)
{
return _defaultContentLoader.GetChildren<T>(contentLink);
}
return _reviewsContentLoader().GetChildrenWithReviews<T>(contentLink).ToList();
}
barteksekula
This is a confirmed issue on the latest version of advanced-reviews version 1.3.7
We have content editors that were running into issues when trying to create preview links on a few pages in the site. I've pulled down the advanced reviews package locally to inspect why the stack is getting so large to the point of crashing the server.
I think I've boiled down the issue to an infinite loop happening when GetChildrenWithReviews() is called in the ReviewsContentLoader.cs file. For some reason it's being called with a ContentReference with an id of 2. This causes the code to recursively call itself. After some research, I found this ID of 2 is a reference to the Waste Basket in Optimizely. However we're not referencing the Waste Basket on the page anywhere.