advanced-cms / time-property

Episerver property used to store time between 0-24 hours
Apache License 2.0
0 stars 0 forks source link

Support for .NET 6 and CMS 12.11 #7

Closed jsalwen closed 1 year ago

jsalwen commented 1 year ago

We are currently using this (it is great!) on CMS 12.4 and .NET5. We are in the process of upgrading to CMS 12.11 and .NET6.

During build, we now get this warning:

warning NU1608: Detected package version outside of dependency constraint: Advanced.CMS.TimeProperty 2.0.0 requires Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation (>= 5.0.12 && < 6.0.0) but version Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation 6.0.11 was resolved.

It actually works fine with .NET 6 Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation

I suggest either change the current version to increase Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation to 5 and 6, or create a new build for .NET6.

I'd be happy to help with the pull request and testing if you tell me which approach you want to take.

Thanks in advance

barteksekula commented 1 year ago

Fixed in https://nuget.optimizely.com/package/?id=Advanced.CMS.TimeProperty&v=3.0.0

jsalwen commented 1 year ago

thank you!!