search

advanced-cropper / react-advanced-cropper

The react cropper library that embraces power of the advanced cropper core to give the possibility to create croppers that exactly suited for your website design
https://advanced-cropper.github.io/react-advanced-cropper/
Other
707 stars 34 forks source link

Additional icons #3

Closed jurica-penjgusic closed 2 years ago

jurica-penjgusic commented 2 years ago

We were wondering where can we get additional icons similar to icons that were used in example repo?

Norserium commented 2 years ago

@jurica-penjgusic, hello! Which ones? There are many different icons (at the main page, recipes and etc.). Generally, it's a mix icons from different sources and mine own icons. The documentation was rewritten from vue-advanced-cropper documentation, so it has the long history.

jurica-penjgusic commented 2 years ago

Tnx for quick response, probably edit and upload image.

Norserium commented 2 years ago

@jurica-penjgusic, well, I don't understand your last phrase. Do you need the edit and upload images that similar to some sort of icons? Which one?

jurica-penjgusic commented 2 years ago

It would be great if you have, "Upload from computer icon", "Edit icon".

Norserium commented 2 years ago

image Currently I have the following icons, that was prepared for the upcoming example.

Norserium commented 2 years ago

@jurica-penjgusic, what does edit icon mean in your context?

jurica-penjgusic commented 2 years ago

Hi, this example that will be uploaded is awesome!! Good job 👏🏻👏🏻👏🏻

For edit icon, I am referring on pickers that preserve original image and enable users to remodify picture. If you look linkedin profile photo cropper. They enable users to edit current image by adding some filters, resize it, rotate it…. If users want to original photo they can, they just remove all filters and it will work.

Norserium commented 2 years ago

@jurica-penjgusic, could you take some screenshots of LinkedIn? It would be helpful for me. Do you want to implement the similar functional with filters?

Norserium commented 2 years ago

Hi, this example that will be uploaded is awesome!!

Actually, it's not the new example. The new one is better. I just move the download and upload buttons to the example at the main page for the screenshot.

Norserium commented 2 years ago

@jurica-penjgusic, is your issue resolved?

jurica-penjgusic commented 2 years ago

Yep, the example that will go with. ext release is reallly good! So we decided to go on that aproach. Looking forward to see it in action!

Norserium commented 2 years ago

@jurica-penjgusic, I assume there was a little misunderstanding.

I've said, that I created icons for the upcoming example. This example is published now.

I have no plans to add them to the examples of the cropper wizard like I showed on the screenshot above for the demonstration purpose, but you can use that icons in your own cropper: \, \.

jurica-penjgusic commented 2 years ago

Oh, it’s already created, nice work! Tnx for the icons. Keep up with the good work!!!

Get Outlook for iOShttps://aka.ms/o0ukef

From: Norserium @.> Sent: Saturday, June 18, 2022 1:34:45 PM To: Norserium/react-advanced-cropper @.> Cc: jurica-penjgusic @.>; Mention @.> Subject: Re: [Norserium/react-advanced-cropper] Additional icons (Issue #3)

@jurica-penjgusichttps://github.com/jurica-penjgusic, I assume there was a little misunderstanding.

I've said, that I created icons for the upcoming example. This examplehttps://norserium.github.io/react-advanced-cropper/docs/tutorials/image-editor is published now.

I have no plans to add them to the examples of the cropper wizard like I showed on the screenshot above for the demonstration purpose, but you can use that icons in your own cropper: https://github.com/Norserium/react-advanced-cropper/blob/master/example/src/components/icons/DownloadIcon.tsx, https://github.com/Norserium/react-advanced-cropper/blob/master/example/src/components/icons/UploadIcon.tsx.

— Reply to this email directly, view it on GitHubhttps://github.com/Norserium/react-advanced-cropper/issues/3#issuecomment-1159448884, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGIVET2HYVXFAWZGYJS2JZ3VPWX5LANCNFSM5X27OPQQ. You are receiving this because you were mentioned.Message ID: @.***>

Norserium commented 2 years ago

@jurica-penjgusic, you are welcome!