search

advanced-cropper / vue-advanced-cropper

The advanced vue cropper library that gives you opportunity to create your own croppers suited for any website design
https://advanced-cropper.github.io/vue-advanced-cropper/
Other
933 stars 130 forks source link

Feature - send headers #126

Closed meHimanshu closed 3 years ago

meHimanshu commented 3 years ago

able to send headers in props along with image urls solves issue when need to set custom header values to get image data

Norserium commented 3 years ago

@meHimanshu , thank you for your pull request.

Alas, this pull request doesn't solve your issue, because headers are sent only in one of three requests. The getImageData method is used to get the binary image representation and extract an image orientation, images for preview and background are received by two independent browser requests (from <img />), that won't have custom headers.

Anyway, it's pretty uncommon to send additional request headers to get an image. What's your use-case?

meHimanshu commented 3 years ago

Hi @Norserium, we can close the PR as we have solved the issue on our end

meHimanshu commented 3 years ago

Thanks @Norserium