advanced-rest-client / arc-electron

Advanced REST Client - Desktop application
Other
1.41k stars 226 forks source link

Global Request Timeout Broken in 16.0.0 #401

Closed jgordon354 closed 3 years ago

jgordon354 commented 3 years ago

Expected Behavior Expected global request timeout to place an upper time limit on the lack of a response.

Actual behavior Setting the global request timeout seems to have no effect: ARC seems to wait indefinitely.

To Reproduce 1) Set the global request timeout under AdvancedRestClient > Preferences to 10 seconds. 2) Ensure that request configuration is disabled for your request. 3) Send a simple GET request that will receive no response (sent to an Anypoint Studio flow with a breakpoint set). 4) Note that ARC spins indefinitely awaiting a response despite the 10 second timeout setting.

Screenshots N/A

Additional Information

jarrodek commented 3 years ago

I identified the problem. The restored from the config value is not parsed as a number: https://github.com/advanced-rest-client/arc-electron/blob/master/src/app/scripts/arc/AdvancedRestClientApplication.js#L518 Since the config is considered insecure content this should be done when setting the timeout value. When a request is generated the HTTP request processor only tests whether the timeout is a string and ignores other types. I will fix this today or tomorrow.