search

advanced-rest-client / arc-electron

Advanced REST Client - Desktop application
Other
1.41k stars 224 forks source link

Unwanted multiple instances on Mac #70

Closed kamenov closed 6 years ago

kamenov commented 6 years ago

Details

Unwanted multiple instances on Mac OS: macOS High Sierra 10.13.4 App version: 12.1.3

Steps to reproduce

  1. Start the application (from Dock or Spotlight)
  2. Click on the app icon in the Dock

Expected

Primary window is set on focus

Actual

A new instance (window) of the app is started

jarrodek commented 6 years ago

Thanks for the feedback. It has been changed when I realized that on mac after closing an app it's not starting again. I need to test this behavior better. I will fix this.

kamenov commented 6 years ago

When you press the red window button (close) you are actually only closing the window instead of closing the whole app. If you need help testing that and any other changes let me know, as I use the app quite frequently. I'm happy to pull a branch, build it locally and check the new behaviour before you decide to merge it in master and making an official release.

jarrodek commented 6 years ago

Thanks! The "dev" build is always "develop" branch. I always merge feature branch with develop before starting new release process. Contact me at arc@mulesoft.com so I can figure out how to formalize beta testing of the app.

RudyOnRails commented 6 years ago

Very glad to see that this is being worked on - shows activity for this nice repo/tool. I work on an API and like to make/save specific calls to different environments without committing shell scripts with u:p info to git. It's a goto tool when I have these needs. Thanks for building @jarrodek !

Galkon commented 6 years ago

Need this fixed ASAP! It should be a rather simple fix. I am an electron dev myself. I love this app, just installed the full version rather than the chrome extension. This bug is just absolutely brutal in a fast paced dev environment.

kamenov commented 6 years ago

I've found a method on the electron API that prevents multiple instances https://github.com/electron/electron/blob/v0.36.10/docs/api/app.md#appmakesingleinstancecallback

Please fix this as soon as possible as I'm close to switching to an alternative solution.