search

advanced-security / codeql-extractor-iac

CodeQL Extractor, Library, and Queries for Infrastructure as Code
MIT License
40 stars 5 forks source link

[Bug]: The IaC results use absolute paths #138

Open lukaspj opened 6 months ago

lukaspj commented 6 months ago

What happened?

The results from this IaC extension has absolute paths somewhere, which means that GitHub can't link issues to the file. The results from clicking the "view file" button here: image Goes to: https://github.com/{org}/{repo}/blob/main//home/runner/work/{repo}/{path}.Dockerfile#L51

Version

0.1.0

Relevant log output

No response

GeekMasher commented 6 months ago

Thanks for raising this @lukaspj, sad I am away the rest of the week and next. Does this urgently need fixing?

lukaspj commented 6 months ago

Nope, it only applies to what it considers as syntax errors, so it doesn’t affect all our repositories and the syntax error should be fixable if we can figure out what it doesn’t like

GeekMasher commented 6 months ago

When you say "syntax errors", is that in the Dockerfile or something else? Maybe there is an issue with the parser / analysis

lukaspj commented 6 months ago

Well I only know what’s in the screenshot 😅

but it’s only an issue in a single repo