search

advanced-security / maven-dependency-submission-action

GitHub Action for submitting Maven dependencies
MIT License
46 stars 27 forks source link

Distinguish between multiple dependency snapshots of the same type #88

Closed david-wiggs closed 1 month ago

david-wiggs commented 1 month ago

This is a re-cut of #80 (as it got a bit stale) after some testing and comments from @ebickle. In general, it addresses #73 and should hopefully help those that use a matrix approach.

hmaurer commented 1 month ago

@david-wiggs 👋 my apologies for the delay in reviewing this. I am wondering if we could instead omit the correlator input and automatically specify it based on directory. It would be a breaking change for existing users so we'd need to release this under a new major version, though 🤔

All in all I think this change is okay and it'll be useful for folks to be able to override the correlator as an escape-hatch; I'm 👍 for release this.

david-wiggs commented 1 month ago

Hey there @hmaurer thank you for your review and comments

I am wondering if we could instead omit the correlator input and automatically specify it based on directory.

Yes, I think this is a good approach for an additional change. Thank you for approving this one, as it unblocks a current use case. Is there an expectation on when this might get merged?