search

advanced-stack / py-llm-core

A pythonic library providing light-weighted interface with LLMs
MIT License
103 stars 8 forks source link

Greetings. I am guessing this awesome library does not work on Windows? #16

Closed Tron-05 closed 1 month ago

Tron-05 commented 1 month ago

Greetings. I am guessing this awesome library does not work on Windows? It seems to have a Linux/Unix/MacOS path only. Please advise, thank you : )

raise ValueError(f"Model path does not exist: {model_path}")

ValueError: Model path does not exist: C:\Users\kajuk/.cache/py-llm-core/models\BakLLaVA-1-Q4_K_M.gguf

C:_01Sync\Sync\001_Teaching\01_Courses\CSC444 DL\LLAVA Macbook only Test>

paschembri commented 1 month ago

Using pathlib here should resolve the issue on windows

model_path = os.path.join(MODELS_CACHE_DIR, self.name)

https://github.com/advanced-stack/py-llm-core/blob/e99f0930f448e7590bd6b6a0b90cc28605419e08/src/llm_core/llm/llama_cpp_compatible.py#L54

paschembri commented 1 month ago

Fixed in 2.8.5