advancedforms / advanced-forms

WordPress plugin to create forms using Advanced Custom Fields
75 stars 14 forks source link

Problems with file upload field since ACF 5.12.3 release #111

Closed mishterk closed 2 years ago

mishterk commented 2 years ago

The 5.12.3 release adds file upload nonce fields which, instead of being added to the $_POST array like other ACF nonce fields, have been added to the $_POST['acf'] array which typically has all field values.

In our \AF_Core_Forms_Submissions::create_submission() method, we're looping through the array, creating fields, and handling values but since 5.12.3, the file nonce entries cause an issue because they can't return a field array. This might be all we need to do to protect against this situation now and in the future: https://hookturn.io/wp-content/uploads/2022/08/afp-file-upload-fix.jpg

Note this only seems to happen with the basic uploader, not the WP uploader.

Need to add a patch for this and ship.