search

advancedforms / advanced-forms

WordPress plugin to create forms using Advanced Custom Fields
75 stars 14 forks source link

Remove language files #38

Closed tyrann0us closed 6 years ago

tyrann0us commented 6 years ago

The translation template file (advanced-forms.pot) is outdated, preventing users to add custom translations for strings not found in the template with plugins like Loco Translate.

Also, GlotPress should be used to handle translations. For Polish, see https://translate.wordpress.org/locale/pl/default/wp-plugins/advanced-forms. Since load_plugin_textdomain() is missing anyway (which is okay) the translations can be removed safely.

fabianlindfors commented 6 years ago

Hi! The plugin does contain a load_textdomain in advanced-forms.php although it might not be correct. What is required to make the plugin work with translate.wordpress.org? That would be great!

tyrann0us commented 6 years ago

In #39, I pasted links to the WordPress Slack where you'll find detailed logs on what's wrong.

The plugin does contain load_textdomain in advanced-forms.php although it might not be correct.

Yes, plugins should use load_plugin_textdomain() but as I said, this is not required anymore.

fabianlindfors commented 6 years ago

Seems as if Wordpress can't detect the load_plugin_textdomain call. Probably because I have a check for ACF Pro before which interrupts the plugin load or because I'm calling load_textdomain. I'm trying to maintain backwards compatibility so I won't remove the call but I have refactored and changed to the correct function call with commit c584c5101885ecd615745dc531333c9aa65077af.

I'll have to wait for the next release to see if GlotPress will work otherwise I'll check this PR out again. Thank you!