search

advancedrei / sendgridplus-csharp

13 stars 7 forks source link

Attachments #10

Closed HakanL closed 10 years ago

HakanL commented 11 years ago

Fixes #6 I've tested this now and images show up fine in Outlook 2013, GMail and Ios. The only issue with Ios is that it show the images both as inline and attachments. It's apparently a "feature" of the Ios mail client and I don't think this is related to my changes or SendGrid.

HakanL commented 11 years ago

Note that I didn't implement this for the Mail.Portable project. It should be easy, but I didn't.

robertmclaws commented 11 years ago

Hakan,

Thanks for these. I'm going to have to evaluate them closely, because some of your changes break the API for existing users. I'm going to have to look at the net effect of the changes and see if I can work them in some other way, and apply them to the Portable library as well.

I'll take a look at this in a few days and let you know.

Thanks!

-Robert

HakanL commented 11 years ago

Yea I had to do some breaking changes because the existing API wasn't allowing any additional attributes with the attachments, and I also didn't think it made a lot of sense to differentiate between a stream and file attachment, in the end they both attachments, just added differently.