search

advancedtelematic / meta-updater

OTA Software updates using OSTree
MIT License
161 stars 61 forks source link

image_types_ota.bbclass: use standard ext4 features #796

Closed ricardosalveti closed 3 years ago

ricardosalveti commented 3 years ago

Avoid removing 64bit and metadata_csum by default and prefer the standard ext4 features instead.

64bit enables the file system to be larger than 2^32 blocks and metadata_csum enables metadata checksumming, both of which are enabled by default on recent mke2fs releases.

It is unclear why 64bit was disabled by looking at the git history, but my assumption would be that either kernel or userspace was old enough for this feature to not be supported/available. Since this option is currently used by most distros by default, it should now be safe to enable it (requires kernel >= 2.6.28).

metadata_csum was disabled in 4d34fa53db to make the u-boot tooling work with the ext4 file system (when saving environment), but the correct fix should instead be a fix at the userspace tooling instead, since not every target requires u-boot.

This is a follow up of https://github.com/advancedtelematic/meta-updater/pull/791.

Signed-off-by: Ricardo Salveti ricardo@foundries.io

ricardosalveti commented 3 years ago

@liuming50 ^

liuming50 commented 3 years ago

@liuming50 ^

Looks good and clear to me!

pattivacek commented 3 years ago

This looks fine to me, just trying to sort an issue with the test infrastructure.