search

advancedtelematic / ota-community-edition

End-to-end Over The Air updates
Mozilla Public License 2.0
54 stars 24 forks source link

Migration to Helm charts #94

Closed ivankliuk closed 4 years ago

ivankliuk commented 5 years ago

JWT_ISS_PATTERN: 'https://auth-plus.advancedtelematic.com'

Curious, didn't know it's still in use. Can you clarify what's this for?

It should not be used in Community Edition. I will remove it.

bclouser commented 5 years ago

What is the addition of these "internal" services? Both tuf-reposerver and treehub now have these deployment-internal.yaml files which adds tuf-reposerver-internal and treehub-internal pods to the deployment. What are they? are they needed for production?

Edit: It looks like they aren't additional deployments, so i guess it's just a naming thing. Why add the "-internal" suffix ?

bclouser commented 5 years ago

What is the latest on this? I would like to see this move into master. We have our own fork of this branch which we are using currently, and it would be nice to start migrating and submitting pull requests against this so that we can one day get on common code.

simao commented 4 years ago

This PR is not good to merge, it uses aws elbs rather than ingress and is not compatible with minikube. The developer who created this PR is no longer working on this project.

Closing this, if anyone wants to open another PR to use helm charts please feel free.