search

advancedtelematic / quickcheck-state-machine

Test monadic programs using state machine based models
Other
204 stars 25 forks source link

Relax QuickCheck bound #359

Closed mrBliss closed 4 years ago

mrBliss commented 4 years ago

In 81a6c1c8376d72c570bbfc65b626e67687c36d59 and a3050887cda78e216bc4222bccbc8594528cc637, the QuickCheck bound was bumped from 2.9.2 to 2.13.1 to 2.13.2, while 2.12 is already low enough.

mrBliss commented 4 years ago

I have compiled and tested with QuickCheck-2.12 and there seem to be no regressions.

Bumping the dependency on QuickCheck in https://github.com/input-output-hk/ouroboros-network/ is a lot more work than simply relaxing this over-restrictive bound, hence this PR. If this PR is merged, we can bump our dependency on quickcheck-state-machine to HEAD.

mrBliss commented 4 years ago

@rdanitz: Can you please merge the three open PRs? (I don't have admin rights any longer so I cannot override the failing CI.)

@rdanitz: Maybe you should give @stevana admin rights again?

rdanitz commented 4 years ago

It was never supposed that @stevana was stripped of his rights in the first place ;) Now you should be able to merge again.