CI Fixes - Githubissues

advancedtelematic / quickcheck-state-machine

Test monadic programs using state machine based models

Other

204 stars 25 forks source link

CI Fixes #360

Closed kderme closed 4 years ago

kderme commented 4 years ago

Some fixes:

.gitignore is impoved
persistent version is bumped, to use the new runMigrationQuiet. The SQLite test now doesn't flow stdoutput.
rqlite test only runs when docker is installed.
The docker rqlite image version is specified. A newer version was recently released, but it breaks compatibility with hs-rqlite and makes the test fail consistently. ~Unfortunately, this doesn't fix the existing bug with rqlite test. So it's still possible to fail.~
rqlite bug fixed

stevana commented 4 years ago

A newer version was recently released, but it breaks compatibility with hs-rqlite and makes the test fail consistently. Unfortunately, this doesn't fix the existing bug with rqlite test. So it's still possible to fail.

So what's the plan here?

stevana commented 4 years ago

It's green! Is this good to go, or still work in progress?

kderme commented 4 years ago

Good to go for me :)

stevana commented 4 years ago

You’re not authorized to merge this pull request.

Geez, who put all this security in?! ;-(. Ping @rdanitz