search

advantageous / qbit

The Java microservice lib. QBit is a reactive programming lib for building microservices - JSON, HTTP, WebSocket, and REST. QBit uses reactive programming to build elastic REST, and WebSockets based cloud friendly, web services. SOA evolved for mobile and cloud. ServiceDiscovery, Health, reactive StatService, events, Java idiomatic reactive programming for Microservices.
http://advantageous.github.io/qbit/
Apache License 2.0
709 stars 140 forks source link

afterMethodCallOnServiceQueue is not called after service method call #761

Open lijishuai opened 8 years ago

lijishuai commented 8 years ago

setAfterMethodCallOnServiceQueue(..) , but not called. I find the problem in function BaseServiceQueueImpl.doHandleMethodCall(...) If the service method return ServiceConstants.VOID , afterMethodCall will be lost. I think something is wrong when I set afterMethodCall... but not be invoked. I find the receiver handler of ServiceQueue's responseQueue does not invoke afterMethodCall in function CallbackManagerWithTimeout's method handleResponse(...) thanks.

RichardHightower commented 8 years ago

Do you want to try a patch? PR?

lijishuai commented 8 years ago

I can do it, but maybe after some days. because I'm very busy on work now. so ... I have some other advice on sync -> async call when refactor old sync source code. will new a issue.

RichardHightower commented 8 years ago

Ok.. Sounds good. I look forward to the PR. Thanks for using QBit and keep the feedback coming.

RichardHightower commented 8 years ago

If you don't have time for a PR, try at least a code sample or unit test that shows the problem.