search

adventistchurch / alps-gutenberg-blocks

A Wordpress plugin to create Gutenberg plugins that work for ALPS.
4 stars 6 forks source link

v3.23 Media Testimonies Gutenberg block development. #24

Closed kelscahill closed 4 years ago

kelscahill commented 4 years ago

Closes #23

kelscahill commented 4 years ago

@designerbrent Those updates are now made. Just let me know if you still have the cursor issue and what browser you are testing in. Locally it was hard for me to replicate the issue.

designerbrent commented 4 years ago

@kelscahill Regarding the extra blocks, this took care of that.

The the Unable to Type in "Enter Quote" area, I'm wondering if it's my install. I had the same problem in both Firefox and Chrome on another block. I can type on both blocks, but I can't paste into it, though on some live sites, it works fine. I probably need to install a new local dev environment as it's a bit mucked up from all the testing.

The only issue left is that the preview images are only showing at a short height for me on both Firefox and Chrome. 2020-04-21 at 3 23 PM

Thanks.

kelscahill commented 4 years ago

@designerbrent I believe the image issue was due to the new Wordpress version and I implemented a fix. Let me know if you have any other issues.

I am still unable to replicate the quote field issue, so something on your local may need to be updated.

designerbrent commented 4 years ago

@kelscahill Please fix the conflicts and then this is good to go.

kelscahill commented 4 years ago

@designerbrent I was finally able to replicate the issue with not being able to paste. Seems like the setting isSelected: false, prevents it. The merge conflict is fixed and you should be able to paste now.