search

adventistchurch / alps-gutenberg-blocks

A Wordpress plugin to create Gutenberg plugins that work for ALPS.
4 stars 6 forks source link

fix(latest-posts): tag list limit #34

Closed sergsadovyi closed 3 years ago

sergsadovyi commented 4 years ago

Increased limit in query from 100 to 999. Autocomplete is also possible, but requires more complex refactoring. Should the autocomplete be added? @designerbrent

designerbrent commented 4 years ago

@sergsadovyi Yes, please switch these to autocomplete

sergsadovyi commented 4 years ago

Autocomplete for Latest Posts component will have conflicts with #36 . Let's merge this PR. And I'll add autocomplete while refactoring the component in #36

@designerbrent

sergsadovyi commented 3 years ago
  1. Added custom REST endpoint to get all tags. The default endpoint has a limit of 100.
  2. It is possible to select multiple tags. Suggestions are showed while typing the tag name.
  3. The FormTokenField component from Core is used to handle tag selection.
  4. Gutenberg has a new component ComboboxControl, that will fit better our needs. It shows the dropdown list of items without the need of typing some symbols. But we should wait when the Gutenberg components will be updated in Wordpress Core. https://developer.wordpress.org/block-editor/components/combobox-control/
designerbrent commented 3 years ago

@sergsadovyi regarding item 4 above, are you thinking we should use what we have here and add the ComboboxControl in later, or wait to merge this till then?

sergsadovyi commented 3 years ago

I think it is better to merge this PR. It fixes the bug of some tags not available in suggestions on websites with more than 100 tags. When Wordpress Gutenberg blocks update to new version, I'll change the input to ComboboxControl.