Refactor blocks - Githubissues

adventistchurch / alps-gutenberg-blocks

A Wordpress plugin to create Gutenberg plugins that work for ALPS.

4 stars 6 forks source link

Refactor blocks #37

Closed designerbrent closed 3 years ago

designerbrent commented 4 years ago

After review by @sergsadovyi, we found that the blocks will need to be refactored to improve maintainability and reliability in the future.

The blocks in question are:

[x] accordion
[x] blockquote
[x] content-block
[x] content-expand
[x] content-show-more
[x] highlighted-paragraph
[x] image-breakout
[x] image-2up
[x] gallery
[x] latest-posts
[x] media-testimonies
[x] media-testimony
[x] cta

YauheniKapliarchuk commented 3 years ago

Hi @sergsadovyi @designerbrent ,

Do we really need refactoring Content-Expand block, because it looks like the new one Inline-Sidebar?

Thanks

designerbrent commented 3 years ago

It may not need to be refactored.

On Dec 13, 2020, at 08:15, Yauheni Kapliarchuk notifications@github.com wrote:

Hi @sergsadovyi @designerbrent ,

Do we really need refactoring Content-Expand block, because it looks like the new one Inline-Sidebar?

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

YauheniKapliarchuk commented 3 years ago

Just for update information about this ticket

PR - https://github.com/adventistchurch/alps-gutenberg-blocks/pull/52

I thing we can close this ticket