adventistchurch / alps-gutenberg-blocks

A Wordpress plugin to create Gutenberg plugins that work for ALPS.
4 stars 6 forks source link

Gallery: fix image size select #39

Closed sergsadovyi closed 4 years ago

designerbrent commented 4 years ago

One quick (i hope) issue to address on this: It is forcing all the images into a horizontal aspect ratio by cropping the images to a horizontal image. Can we display the image in the correct aspect ratio?

sergsadovyi commented 4 years ago

Added new class to ALPS for this fix. Please merge the https://github.com/adventistchurch/alps/issues/490 first

designerbrent commented 4 years ago

I've merged the https://github.com/adventistchurch/alps/pull/490 PR but haven't seen any change in the behavior of the gallery yet.

sergsadovyi commented 4 years ago

adventistchurch/alps#490 adds u-background--contain class to the ALPS css. Current PR will change Gallery behaivor.

designerbrent commented 4 years ago

I'm seeing no change in the gallery, even after pulling this most recent change of this PR. What I'm seeing on the back-end of this, and a newly inserted gallery is this:

Backend

2020-08-05 at 7 21 AM

Frontend

2020-08-05 at 7 22 AM

sergsadovyi commented 4 years ago

Fixed