adventistchurch / alps-gutenberg-blocks

A Wordpress plugin to create Gutenberg plugins that work for ALPS.
4 stars 6 forks source link

[v3.523] Media block #48

Closed sergsadovyi closed 3 years ago

sergsadovyi commented 3 years ago

Beta version of the Media block. @designerbrent please check in different layouts.

To enable this block in the editor you need to add alps-gutenberg-blocks/media-block to allowed_block_types in ALPS theme functions.php.

designerbrent commented 3 years ago

This is a going in the right direction and on the surface it works for the left aligned blocks. However I have some concerns after further reviewing the code:

Moving forward, I would like to see the following changes made:

The j

designerbrent commented 3 years ago

One more thing I forgot to add: We need to add the following CSS when the blocks are loaded on the front end, in case they are loaded into a column component:


.wp-block-column .c-media-block, 
.wp-block-column .c-block__image, 
.wp-block-column .c-block__content {
  width: auto;
}
designerbrent commented 3 years ago

Here is the correct classes for the two blocks in the 2 states:

Sidebars:

Left:

Centered:

No Sidebars:

Left:

Centered: