search

adventistchurch / alps-gutenberg-blocks

A Wordpress plugin to create Gutenberg plugins that work for ALPS.
4 stars 6 forks source link

V3.511 inline sidebar #49

Closed YauheniKapliarchuk closed 3 years ago

YauheniKapliarchuk commented 3 years ago

Hi,

I need your review for this component.

@designerbrent

  1. Can you give me some instruction for design of this component in Editor?
  2. Can I fix issues with close icon in the button?

Screen Shot 2020-12-02 at 20 18 58 Screen Shot 2020-12-01 at 21 31 14 Screen Shot 2020-12-01 at 21 31 19

YauheniKapliarchuk commented 3 years ago

Hi, @designerbrent

I investigated question about "Headings" and "Lists" for inline sidebar.

Currently functionality of WP doesn't support extending default "Headings" and "Lists" for our components.

I propose:

  1. to implement just new "Headings"(a few days for this component) component (because implementation "Lists" component need much effort) for our needs and we will wait when WP team update functionality for using default components;
  2. leave everything as it is and do not spend time for this functionality.

Thanks

designerbrent commented 3 years ago

Let's go with option 2 and just leave it as is. We an come back to adding headings and lists later, if needed.