search

adventistchurch / alps-gutenberg-blocks

A Wordpress plugin to create Gutenberg plugins that work for ALPS.
4 stars 6 forks source link

#342 CTA block development #9

Closed kelscahill closed 5 years ago

kelscahill commented 5 years ago

Closes #342 in ALPS-WP. This PR will need to be merged as well: https://github.com/adventistchurch/alps-wordpress/pull/359

Also, the image does not have the responsive sizes, but it will be addressed in https://github.com/adventistchurch/alps-wordpress/issues/334

kelscahill commented 5 years ago

This is ready for review!

designerbrent commented 5 years ago

@kelscahill I'm sure I'm missing something but the CTA block isn't showing for me at all when I test this branch. Do I need to run something to compile it?

kelscahill commented 5 years ago

@designerbrent I just rebuilt the files. That could have been the issue. Try again and let me know if it works.

designerbrent commented 5 years ago

@kelscahill Still no luck. Is there a cache that I should be clearing?

kelscahill commented 5 years ago

@designerbrent The gutenberg blocks do cache to some extend. Try in incognito mode. Can you confirm you did pull the latest files from the branch and added them to your local plugins directory?

designerbrent commented 5 years ago

@kelscahill I'm stumped. I have the v3.342-cta-block branch checked out. I removed it to prove to myself that I was on the right install. I have tried incognito mode. I have tried deleting the /uploads/cache folder.

All of these has been to on effect. Are you sure that everything got checked in?

designerbrent commented 5 years ago

So i found my problem. I was not running the updated version of the theme, thus it wasn't showing. Oops. I pulled that and it worked fine.

kelscahill commented 5 years ago

Okay great! I was troubleshooting, but couldn't seem to replicate. Glad you were able to get it working.