search

adventistchurch / alps-wordpress

This Wordpress theme is an implementation of the Adventist Living Pattern System (ALPS) designed to support the work of the Seventh-day Adventist Church.
Other
43 stars 38 forks source link

Create child theme for custom homepage #449

Closed kelscahill closed 4 years ago

kelscahill commented 4 years ago

Convert all the new components on https://www.adventist.org/ to Carbon custom fields. Add all the development work as a child theme.

kelscahill commented 4 years ago

@designerbrent How would you like to track the development of the child theme changes in github? Is it best to create a new repo alps-wordpress-child? The child theme files will be located in themes/alps-v3-child

designerbrent commented 4 years ago

@kelscahill I have created a new project here: https://github.com/adventistchurch/alps-wordpress-child that will be for the public. The theme that will go on Adventist.org will be in another private repo.

kelscahill commented 4 years ago

@designerbrent Thanks for creating the repo! I have the child theme ready for review. All the files are pushed to master at https://github.com/adventistchurch/alps-wordpress-child. Please just make sure your parent theme folder is labeled alps-v3 and set the homepage as Front page inSettings >Reading for the ALPS: Page Sections fields to display.

designerbrent commented 4 years ago

@kelscahill

I tested the child theme and have a few notes:

  1. I renamed the parent theme in the child theme to be what we default to, alps-wordpress-v3 to keep things consistent.
  2. I'm unsure what views > front-page.blade.php does. When I set a front page like we have for Adventist.org, it doesn't look like that. When I use the default front page, it looks like the attached screenshot, with every post having the full page header. What did you intend for this to do?

2020-04-21 at 2 32 PM

What I was thinking would be that this is nearly done. All that would be needed would be the addition of some information in the README on how to add template override files to this theme.

My intent was that the version of this for adventist.org would be located in this repo: https://github.com/adventistchurch/alps-wordpress-aorg and would be like this but using the custom front-page file that is on adventist.org now.

Does that make sense?

kelscahill commented 4 years ago

@designerbrent The renaming of the folders would have broken the child theme. I've updating the settings and the README requirements. Here is a short video of the steps to enabled the custom fields for the front page. https://d.pr/free/i/oGmOGC

When you say What I was thinking would be that this is nearly done., do you mean all the content would be populated? For adventist.org, you'll just need to recreate the page with the custom fields, so all the data is in the database.

Let me know if you have any other questions and we could hop on a zoom to discuss.

kelscahill commented 4 years ago

@designerbrent I did some testing to replicate the repeating template on the homepage and everything seems to be working as expected. Try a fresh DB and see if that does the trick. Also, I made the updates to the child themes from our discussion yesterday. The custom fields are now moved to https://github.com/adventistchurch/alps-wordpress-aorg and https://github.com/adventistchurch/alps-wordpress-child is a blank child starter theme.

designerbrent commented 4 years ago

@kelscahill from what I can tell, the child theme looks great. I have a project coming up that I will be having the contractor use this, so we may make some changes, but they will be minor.

I've created a new ticket for you with some minor edits to the Adventist.org version that are here: https://github.com/adventistchurch/alps-wordpress-aorg/issues/1

With that, I'll be closing this ticket.