search

adventistchurch / alps-wordpress

This Wordpress theme is an implementation of the Adventist Living Pattern System (ALPS) designed to support the work of the Seventh-day Adventist Church.
Other
43 stars 38 forks source link

Prevent space between city and comma in footer addresses #676

Closed mattleff closed 11 months ago

mattleff commented 1 year ago

Steps

  1. Add footer address with a state
  2. View footer

Expected result

image

Actual result

image

Note the space between the city and the comma before the state.

This is observable on many ALPS sites.

Notes

The solution in this PR is based on this SO answer. This is necessary because Laravel doesn't consider managing whitespace an important issue:

Heya, that's a known issue and a very hard one to solve given the nature of the compiler. We don't consider this a bug at the moment but rather how things work. However, if anyone wants to dig into resolving this one that'd would be greatly appreciated 👍

Posted by @driesvints in https://github.com/laravel/framework/issues/34931#issuecomment-714569189

YauheniKapliarchuk commented 1 year ago

Hi @mattleff,

I am going to check PR but I want to ask you please do not keep your changes until a new version of the theme is released.

Check status here: https://github.com/adventistchurch/alps-wordpress/pull/668 or on releases in github.

Thanks, Best Regards!

YauheniKapliarchuk commented 11 months ago

Hi @mattleff,

Could you please update your branch before we will merge these changes in our repository?

Thanks, Best Regards!

mattleff commented 11 months ago

@YauheniKapliarchuk Done.