adventistchurch / alps-wordpress

This Wordpress theme is an implementation of the Adventist Living Pattern System (ALPS) designed to support the work of the Seventh-day Adventist Church.
Other
43 stars 38 forks source link

Set Defaults for Display Banner #694

Closed hans-olson closed 11 months ago

hans-olson commented 11 months ago

Please Set Defaults for Banner Display on Header and Page Builder Options

POST DEFAULT SETTING Screenshot 2023-07-18 at 7.26.06 PM.png

PAGE DEFAULT SETTING Screenshot 2023-07-18 at 7.26.40 PM.png

claytonk commented 11 months ago

Sorry for my previous comment, I see you're wanting these as defaults based on page or post. That should be doable, but that mandates that users will have to select an image by default as well.

hans-olson commented 11 months ago

We need the default for Posts to be the 50/50 and Pages the text overlay, based on what appeared before the new header options were introduced.

-Hans

If your religion makes you hate someone, you’re doing it wrong.

From: Clayton Kinney @.> Date: Tuesday, July 18, 2023 at 7:59 PM To: adventistchurch/alps-wordpress @.> Cc: Hans Olson @.>, Author @.> Subject: [EXTERNAL] Re: [adventistchurch/alps-wordpress] Set Defaults for Display Banner (Issue #694)

Not clear which you're wanting set as the default. Are you saying you want a different default based on which template you select? — Reply to this email directly, view it on GitHub https://github.com/adventistchurch/alps-wordpress/issues/694#issuecomment-1641141957, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOVXDKZWKKAQIWUXNR4FCDDXQ4PO3ANCNFSM6AAAAAA2PCWUR4. You are receiving this because you authored the thread.Message ID: @.***>

claytonk commented 11 months ago

Yep, figured that out. I'll work on the change.

claytonk commented 11 months ago

@YauheniKapliarchuk I have a fix ready for this, do you want me to update branch 3.14.4.3 or do you want me to push it as a new branch?

YauheniKapliarchuk commented 11 months ago

Hi @claytonk Could please create PR to v3.1 and after that I will do anything what we need?

Thanks, Best Regards!

claytonk commented 11 months ago

I added this to 3.14.4.3 and created the PR.

YauheniKapliarchuk commented 11 months ago

@claytonk Thank you for these changes!

Best Regards!