Closed hans-olson closed 11 months ago
Sorry for my previous comment, I see you're wanting these as defaults based on page or post. That should be doable, but that mandates that users will have to select an image by default as well.
We need the default for Posts to be the 50/50 and Pages the text overlay, based on what appeared before the new header options were introduced.
-Hans
Hans Olson, PMP, CSPO, (ISC)2 Candidate Email: @. @./> Voice/Text/Signal: +1-202-853-8700 Fax: +1-202-204-5739 Zoom ID: https://adventist.zoom.us/my/hansolson https://adventist.zoom.us/my/hansolson
If your religion makes you hate someone, you’re doing it wrong.
From: Clayton Kinney @.> Date: Tuesday, July 18, 2023 at 7:59 PM To: adventistchurch/alps-wordpress @.> Cc: Hans Olson @.>, Author @.> Subject: [EXTERNAL] Re: [adventistchurch/alps-wordpress] Set Defaults for Display Banner (Issue #694)
Not clear which you're wanting set as the default. Are you saying you want a different default based on which template you select? — Reply to this email directly, view it on GitHub https://github.com/adventistchurch/alps-wordpress/issues/694#issuecomment-1641141957, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOVXDKZWKKAQIWUXNR4FCDDXQ4PO3ANCNFSM6AAAAAA2PCWUR4. You are receiving this because you authored the thread.Message ID: @.***>
Yep, figured that out. I'll work on the change.
@YauheniKapliarchuk I have a fix ready for this, do you want me to update branch 3.14.4.3 or do you want me to push it as a new branch?
Hi @claytonk Could please create PR to v3.1 and after that I will do anything what we need?
Thanks, Best Regards!
I added this to 3.14.4.3 and created the PR.
@claytonk Thank you for these changes!
Best Regards!
Please Set Defaults for Banner Display on Header and Page Builder Options
POST DEFAULT SETTING![Screenshot 2023-07-18 at 7.26.06 PM.png](https://images.zenhubusercontent.com/61f025ec3fa7176b9a631d4e/bfc8f8b0-c0d5-43ed-9a31-36b4144bc941)
PAGE DEFAULT SETTING![Screenshot 2023-07-18 at 7.26.40 PM.png](https://images.zenhubusercontent.com/61f025ec3fa7176b9a631d4e/2aca52d4-a221-4637-ac5b-94b864b44668)