search

adventistchurch / alps-wordpress

This Wordpress theme is an implementation of the Adventist Living Pattern System (ALPS) designed to support the work of the Seventh-day Adventist Church.
Other
43 stars 38 forks source link

script.min.js error / Google maps not displaying #748

Open mcordas opened 4 months ago

mcordas commented 4 months ago

Version of ALPS for Wordpress v3.15.1.7 Wordpress 6.4.3

Describe the bug Since upgrading from Alps for Wordpres 3.13, Maps from WP Go Maps (formerly WP Google Maps) plugin won't show anymore.

I have this error message in developpers tools console on pages with maps (from Google maps) :

"Uncaught TypeError: this.parentElement is null" in script.min.js line 4 character 19019

If I delete script.min.js from "/wp-content/themes/alps-wordpress-v3/app/Local/alps/js", then the error disappears and maps show again. Buth then some other blocks won't show at all, like Youtube.

Also, maps show on iOS or other mobile platform user agents, and there's no error with script.min.js on those platforms.

If I manually change user agent with developper tools, then the maps will show also on MacOS and Windows, and the error disappears from console.

To Reproduce Steps to reproduce the behavior:

  1. display Google maps on any page with Alps for Wordpress 3.1.15.7
  2. View page on any non-mobile platform.

Expected behavior Map is blank

Screenshots Capture d’écran 2024-03-01 à 18 56 47 309348188-7534ad1c-0aa6-46c1-8369-b6ba29e7b232

Capture d’écran 2024-03-01 à 18 56 59

Additional context

YauheniKapliarchuk commented 1 month ago

Hi @mcordas ,

I am going to check it and reproduce it.

hans-olson commented 1 month ago

@mcordas Can you please update to the latest version of ALPS, which is 3.15.2.3.

YauheniKapliarchuk commented 1 week ago

Hi @mcordas,

Sorry for delay,

I did some investigation with our latest version of ALPS v3.15.2.3.

On my environment, everything working as we expected without any errors in console.

Screenshot 2024-06-23 at 7 17 57 PM

Could you please update your version to the latest ALPS v3.15.2.3 and give some feedback?

Thanks, Best Regards!

YauheniKapliarchuk commented 1 week ago

@mcordas Also, if the error isn't gone, you have to reproduce these steps:

  1. Deactivate ALPS theme;
  2. Go to the plugins section and open settings of your Map plugin;
  3. To be sure, that this plugin setting up correct and clear caches on your site, in the other way you can roll back your plugin to Default state (unfortunately);
  4. Activate ALPS theme back.

Thanks, Best Regards!