Update projects to 3.6.0

[ericoporto]

master branch needs to be branched to release-3.5.1

This updates the projects to 3.6.0

• update release date to 2022
• makes the project use utf8 encoding
• sets up TTFMetricsFixup to None
• use new keypress mode
• set the settings option for gui controls to clip
• ctrl+A now is Debug(2,3) to show walkable areas

I am making this a draft until the branches are adjusted plus still need to fix Tumbleweed and create a proper new branch there.

Also apparently previous AGS Editor did not order the tags alphabetically when serializing to XML.

[ivan-mogilko]

In regards to changes, TTFMetricsFixup also has to be adjusted in every font: there's a global setting that acts as default, and individual per-font setting.

[ivan-mogilko]

The branch release-3.5.1 was added.

[ericoporto]

TTFMetricsFixup also has to be adjusted in every font:

@ivan-mogilko so, I noticed in the tumbleweed, that the speech outline font and the speech font have different height when I switch this setting, 11/12 with the setting and 12/14 when I switch to "Do nothing". This makes the outline appear dislocated on the screen, 1 pixel down. I will look if I can edit the font, think I need to make the height bigger in the normal non-outline font.

[ivan-mogilko]

I noticed in the tumbleweed, that the speech outline font and the speech font have different height when I switch this setting, 11/12 with the setting and 12/14 when I switch to "Do nothing". This makes the outline appear dislocated on the screen, 1 pixel down. I will look if I can edit the font, think I need to make the height bigger in the normal non-outline font.

This may be one of those fonts that were created specifically to use in AGS in the past, accomodating for its quirks. In such case the font may be left as is, and have "fixup" set to "Resize ascender...".

[ericoporto]

I wonder if it's best to just delete the outline font and rely on automatic outline from AGS. Since it's a template, I expect people will change the font eventually and then they will need to either make their outline font or just tick a box in AGS. I say this because a common thing to do is to import over the font that is already in the template itself.

By going this route there's no need for such fix-up.

[ericoporto]

ok, I learned how to modify a font ascent (using ttx fonttools command line tools), I managed to fully upgrade the tumbleweed template (https://github.com/dkrey/ags_tumbleweed/pull/11). I just want to double check everything is correct tomorrow.

[ericoporto]

This is ready for review, I upgraded all projects and tumbleweed too

[ivan-mogilko]

Regarding Tumbleweed, you were pushing these fixes to the abstauber's repository, correct?

[ericoporto]

yes, I did push already. I haven't used the tumbleweed template much before but I tested and it seems it's working. I noticed all the stuff in the script that is in different languages got reencoded, it was nice that GitHub picked up and now shows the right characters!

It's all here: https://github.com/dkrey/ags_tumbleweed

After the templates are alright, I think we can move to beta and then I will move to focus on documentation.

[ivan-mogilko]

IMO also has to be changed:

All templates:

• General Settings -> Visuals -> GUI controls clip their contents = True

Empty template:

• each Font: TTF font adjustments = Do nothing

Tubleweed template:

• General Settings -> Character movement -> Scale movement speed with room's mask resolution = False

[ivan-mogilko]

In regards to script, my proposal is to use a simplier form of mod check, i.e. (mod & eKeyModCtrl) instead of ((mod & eKeyModCtrl) != 0); while inside the condition the result is same, but former could be easier to understand to users, i think. But that may be just my vision.

Also, a small nitpick, but there's a discrepancy of a code style in line else if ((mod & eKeyModCtrl) != 0) { the opening brace is on the same line, while it's on separate line everywhere in surrounding script.

[ericoporto]

General Settings -> Visuals -> GUI controls clip their contents = True

I just found a bug, right aligning a label with text that has outline will clip the outline. I am center aligning to prevent this on tumbleweed.

Edit: also added all mentioned changes.

[ivan-mogilko]

I just found a bug, right aligning a label with text that has outline will clip the outline. I am center aligning to prevent this on tumbleweed.

Sounds like this must be fixed in the engine, where it does not account for the outline's thickness when aligning text.

[ivan-mogilko]

Sounds like this must be fixed in the engine, where it does not account for the outline's thickness when aligning text.

Oh, there's also another problem; for some reason engine only uses auto-outline thickness when calculating outline width and height, and ignores outline fonts. This is an old issue.

[ericoporto]

Hey, you will update the repository that has the release artifacts for this one? I don't remember if that one has a release-3.5.1 branch, but if it doesn't, let's do that there so we can at least have 3.6.0 moving forward.

[ivan-mogilko]

Hey, you will update the repository that has the release artifacts for this one? I don't remember if that one has a release-3.5.1 branch, but if it doesn't, let's do that there so we can at least have 3.6.0 moving forward.

Done.

[ivan-mogilko]

Unfortunately I noticed two more issues after the merge, posted 1 issue and 1 pr in Tumbleweed repository https://github.com/dkrey/ags_tumbleweed/issues/14 https://github.com/dkrey/ags_tumbleweed/pull/13

[ericoporto]

Merged the PR, the issue I will look into and edit the font directly.

[ivan-mogilko]

Ok, everything is in sync now. Just for information, when updating template binaries in https://github.com/adventuregamestudio/ags-templates last time i already included hotspot description removal for Tumbleweed, so no more update is required there for now.