search

adventuregamestudio / ags

AGS editor and engine source code
Other
708 stars 159 forks source link

3.6.1: remove "supersampling" setting from OpenGL renderer #2355

Closed ivan-mogilko closed 8 months ago

ivan-mogilko commented 8 months ago

This "supersampling" setting comes from the original mobile port of AGS, but it's not clear whether it was useful. My understanding is that it increases resolution in which game sprites are drawn to a fixed multiplier of 2, but there's already is a "Render in screen resolution" setting that does the similar thing.

More importantly, there are issues with this:

  1. It was never implemented in another hardware accelerated driver (Direct3D), being exclusive to OpenGL.
  2. It was never added to standard setup, so not very visible.
  3. It's not clear whether it was working properly all this time. There have been multiple changes to graphic renderers, and some of them may assume that rendering at "native resolution" is done at exactly, well, native resolution.

UPDATE: Also removed unused "video" "framedrop" setting.

ericoporto commented 8 months ago

I noticed the CI didn't pickup neither the version commit after the merge or the new tag. On GitHub Status there's an existing incident going on with pull requests.

I emailed CirrusCI support in the meantime.

ericoporto commented 8 months ago

Fedor replied and it appears the issue is on GitHub itself.

image

https://www.githubstatus.com/

Hopefully it will soon resume to normal.

If you look into the organization feed, even there this merge haven't generated notification with the actual commits or the commit with version update.