search

adventuregamestudio / ags

AGS editor and engine source code
Other
708 stars 159 forks source link

Editor: fix welcome pane scaling under dpiaware #2369

Closed ericoporto closed 7 months ago

ericoporto commented 8 months ago

Allow scaling of the Welcome Pane, this is step 1/7, partial of #2087

I plan to work on each pane slowly when I find time, in separate PRs, also because these panes have lots of specific details, I think it's better to work them one by one.

Editor at 125% scaling ![image](https://github.com/adventuregamestudio/ags/assets/2244442/6b7e7ccd-821e-4fc5-8ead-c9b24af31963)
Editor at 200% scaling ![image](https://github.com/adventuregamestudio/ags/assets/2244442/402b3660-e8dc-458c-bf3f-5fd4385630d0)

To test this PR I recommend editing the Editor/AGS.Editor/app.manifest and uncommenting the dpi aware setting (lines 52 to 58).

ivan-mogilko commented 8 months ago

Something I noticed: if I repeatedly click "Show another tip", sometimes changing a tip resizes the tip panel horizontally, even though there's enough of vertical space to wrap the tip, and the big "what's new" panel shifts to right and left. This was not happening previously.

ericoporto commented 8 months ago

Can you take a screenshot of this? Does it become larger?

ivan-mogilko commented 8 months ago

I don't think a screenshot will tell much, the difference is tiny, but the shifting is noticeable if you repeatedly click on "next tip".

It looks like the left panel becomes a bit wider, and the main panel becomes a bit smaller.

I might note which exactly tips cause this, if that's necessary (although this may depend on overall window and font sizes?). The question here is mostly why are they allowed to resize like this?

ericoporto commented 7 months ago

The question here is mostly why are they allowed to resize like this?

I made so they could grow horizontally a little too if necessary. But now I removed this and fixed the width, so it can only grow vertically. It appears to work alright at least from 100% to at most 300%. I think this if fine.