search

adventuregamestudio / ags

AGS editor and engine source code
Other
704 stars 160 forks source link

Enable voice-based lipsync for Lucas-Arts speech style #2522

Open ivan-mogilko opened 2 months ago

ivan-mogilko commented 2 months ago

For unclear reasons the voice-based lipsync does not work with Lucas-Arts speech style.

I cannot imagine the reason, as the only difference are character animation and the way text is displayed, neither of that has any relevance to voice or lipsync, and text-based lipsync works with LA style. Could be an intentional restriction for obscure or obsolete reasons, but also could be a non-intentional oversight in code.

Need to investigate this and let voice-based lipsync work with LA style too.

ericoporto commented 2 months ago

Looking at the update code it looks like it can work with any kind of speech

https://github.com/adventuregamestudio/ags/blob/6ce71b446cb7a561dc4fbcec57f71a29547c5b1e/Engine/main/update.cpp#L414-L436

I noticed the playvoicespeech code assumes sierra and it changes the specific type of sierra speech

https://github.com/adventuregamestudio/ags/blob/6ce71b446cb7a561dc4fbcec57f71a29547c5b1e/Engine/ac/global_audio.cpp#L549-L580

I think the easy approach would be to remove the error condition from the editor so it CAN build an Lucas-Arts style with voice lip sync and then fix where things breaks.