AGS 4: cut deprecated commands from dialog script

Dialog script converter still has a support for a number of deprecated commands that should not be used anymore, because they have modern equivalents, and some are based on obsolete script API, such as SetGlobalInt, which has been removed from the engine, so using related commands in dialog will cause compilation errors anyway.

Handling of these commands starts here: https://github.com/adventuregamestudio/ags/blob/bf09c8220395b2b0ebce06e1270f364cfe69a8c5/Editor/AGS.Editor/Utils/DialogScriptConverter.cs#L188

Following commands must be removed, with any connected code:

set-speech-view - this command is not even documented today, user can use normal script function instead;
set-globalint - converts to a deprecated SetGlobalInt, which is cut in AGS 4;
run-script - used to run a dialog_request callback in global script, but that is no longer necessary as you may use normal script in dialogs. dialog_request callback itself has to be kept, because it's run by dialog's text parser.
play-sound - converts to a deprecated PlaySound
add-inv - not necessary, use normal script command
lose-inv - not necessary, use normal script command
new-room - not necessary, use normal script command

There's also a piece of predefined script that has to be removed, related to the run-script command: https://github.com/adventuregamestudio/ags/blob/ags4/Editor/AGS.Editor/Resources/__DialogScripts.asc This is essentially a wrapper around a call to dialog_request, which duplicates a code in the engine which is run when text parser is used in dialog options.

EDIT: Similar changes should also be done to the dlgconv tool: https://github.com/adventuregamestudio/ags/blob/ags4/Tools/data/dialogscriptconv.cpp

adventuregamestudio / ags

AGS 4: cut deprecated commands from dialog script #2557