search

adventureland-community / typed-adventureland

9 stars 4 forks source link

Enable all configs #16

Closed Telokis closed 2 years ago

Telokis commented 2 years ago

In this PR, I tried to enable all configs. Things I noticed:

Some unions take precedence when they should not:

Positions has too many keys PositionKey is insanely huge and matches a lot of strings which feels strange. (Most of the skins and variants have changed from string to PositionKey)

Must be manually handled "cosmetics" and "timestamp" not working with the generator.

thmsndk commented 2 years ago

I think we might want to disable G.docs unsure those types are useful. I am also not too fond of the types generated in G.drops

Telokis commented 2 years ago

I disabled G.docs.
G.drops doesn't match the format expected by the generator, we will have to type it ourselves.