search

advisr-io / excel4node

Node module to allow for easy Excel file creation
MIT License
124 stars 19 forks source link

An "unsafeMerge" option for faster cell merging (without overlapping checks) #33

Open shk-webpr opened 1 year ago

shk-webpr commented 1 year ago

Is your feature request related to a problem? Please describe. The more merged cells worksheet has, the longer it takes to add a new merged cell. Most of this time is spent checking to see if currently merged cells contain cells in new merge request.

Describe the solution you'd like An worksheet option for bypassing these checks.

Describe alternatives you've considered A cell() method argument for bypassing these checks.

Additional context https://github.com/advisr-io/excel4node/blob/master/source/lib/cell/index.js#L231 image

wildhart commented 7 months ago

I'm having this issue too - is there any timeline to make it possible to avoid these checks? I'm happy for my own code to take responsibility for preventing overlapping merged cells...

danielb7390 commented 7 months ago

You can just use the patch-package tool to remove that part of the code from your codebase. That's what i did...

wildhart commented 7 months ago

Thanks @danielb7390 - I've done that.