advisr-io / excel4node

Node module to allow for easy Excel file creation
MIT License
124 stars 18 forks source link

Include TypeScript type definitions #64

Open ghost opened 1 year ago

ghost commented 1 year ago

Is your feature request related to a problem? Please describe. Without TypeScript support / type safety, it's more difficult and error-prone to use, and one needs to refer to documentation more often.

Describe the solution you'd like Ideally, having the type definitions available on installation.

Describe alternatives you've considered The option that users seem to go for currently is manually adding the type definitions after installing the library and maintaining them, which is doable, but not very convenient.

Additional context This was requested previously in https://github.com/natergj/excel4node/issues/188 and some definitions are available there, but it would be nicer if the support was available out-of-the-box. Thank you!

rathoddeepak commented 12 months ago

https://gist.github.com/rathoddeepak/347b0dd91617076433f3242efbbcddbd

Create a folder typings in root dir add this file and add

{
   "compilterOptions": {},
   "include": ["typings/**/*.ts"]
}

this to your tsconfig.json

idchlife commented 7 months ago

Why not upload types to DefinetelyTyped?

clopezpro commented 6 months ago

https://gist.github.com/rathoddeepak/347b0dd91617076433f3242efbbcddbd

Cree una carpeta escribiendo en el directorio raíz, agregue este archivo y agregue

{
   "compilterOptions": {},
   "include": ["typings/**/*.ts"]
}

esto a tu tsconfig.json

I did it with nuxt but it doesn't work

Roman991 commented 1 month ago

https://gist.github.com/rathoddeepak/347b0dd91617076433f3242efbbcddbd

Create a folder typings in root dir add this file and add

{
   "compilterOptions": {},
   "include": ["typings/**/*.ts"]
}

this to your tsconfig.json

maybe make a PR, it will be also easier to find it