search

advplyr / audiobookshelf-app

Mobile application for Audiobookshelf
https://audiobookshelf.org
GNU General Public License v3.0
1.28k stars 173 forks source link

ABS Icon smushed #1105

Open raviwarrier opened 8 months ago

raviwarrier commented 8 months ago

Screenshot_2024-02-26-23-41-05-02_e9782661401ed6f222682e1e02b74bd4.jpg

Don't know if this is new or local, but just saw this.

Android 14. Latest app version (can't remember version, but as of 27th Feb 2024, whatever is the latest version)

nichwall commented 8 months ago

This is how latest app version (0.9.72) looks on my Pixel 6a, Android 14.

Might be due to the download circle taking up extra space?

Screenshot_20240226-115500.png

nichwall commented 8 months ago

The narrow screen may be related to the issue some people have mentioned with the hamburger menu not working (just on the other side) https://github.com/advplyr/audiobookshelf-app/issues/1015

raviwarrier commented 8 months ago

@nichwall yup, it's because of the download circle. forgot to mention it in my half-asleep state. :)

if its the same problem, please go ahead and merge the two issues or close this one.

Cheers buddy.

advplyr commented 8 months ago

What device is that? I'm not sure how to handle this for that narrow of devices. I'm thinking of moving the search to inside the hamburger menu or the cast icon

raviwarrier commented 8 months ago

It's one plus nord 3e. What I was thinking was merge the download progress with the ABS icon. You can do this in multiple ways and I will leave that upto you - a halo ring around the icon, or filling/emptying of the image related to percentage, etc.

when downloading, tapping on the icon takes you to the downloading screen, else, if maintains it current/regular functionality.

Search is perhaps one of the most used features and UI-wise, it would better to leave it outside... If you have to move anything inside the hamburger, move the cast icon.

Edit: Also, if it is downloading, it means, it's connected to the server and there's no need for that green icon to be visible. here's what you can do about that icon:

if connected, show the green icon for a bit and then hide it if disconnected, show the red icon persistently.