search

advplyr / audiobookshelf-app

Mobile application for Audiobookshelf
https://audiobookshelf.org
GNU General Public License v3.0
1.31k stars 173 forks source link

Creating bookmarks for offline media #163

Open raketenhunddev opened 2 years ago

raketenhunddev commented 2 years ago

Steps to reproduce

  1. Download audiobook
  2. Start local playback
  3. Create a bookmark

Expected behaviour

Actual behaviour

Environment data

Audiobookshelf Version: 2.0.8

Android Issue

Android version: 12

Device model: Galaxy S21

Stock or customized system: stock

advplyr commented 2 years ago

In v0.9.44-beta if you are connected to the server you downloaded the item from then bookmarks will be available. Bookmarks are not yet implemented when not connected to the server, that could be a while since it is a big effort.

kaldigo commented 2 years ago

I am still having this problem even on 0.9.49

cinvan2000 commented 2 years ago

I am still having this issue as well on 0.9.51-beta.

Audiobookshelf Version: 2.0.24

Android version: 11

Device model: OnePlus 6

advplyr commented 2 years ago

Downloaded library items have to be linked to a server item for them to show bookmarks and you have to be connected to the same server they are linked.

kaldigo commented 2 years ago

They are linked and on the book details page it does say its connected. On the player at the top it says local and there is no option for bookmarks. The button for them is just missing.

Screenshot_20221008_114552_audiobookshelf.jpg Screenshot_20221008_114727_audiobookshelf.jpg

advplyr commented 1 year ago

Fixed the bug where bookmarks weren't showing for downloaded media when currently connected to server in v0.9.60-beta

We can leave this open for supporting completely offline bookmarks.

mym0T commented 1 year ago

Fixed the bug where bookmarks weren't showing for downloaded media when currently connected to server in v0.9.60-beta

We can leave this open for supporting completely offline bookmarks.

I'm still having this issue in v0.9.61-beta on iOS

To replicate the issue:

  1. Play the book while connected to the server and the bookmark button is visible image

  2. Fully close/kill the app

  3. Re-open the app and allow it to connect to the server image

  4. The book that was previously playing will show in the bar at the bottom with the progress and play button. Tap that bar to view the now playing window, and the bookmarks button will not be visible. image image

To make the button appear again, you can either:

  1. Start playing a different book, then return to the current book.
  2. Tap the 3 dots at the top right corner of the now playing screen, tap close player, then tap the play button on the book again to re-open it. image
advplyr commented 1 year ago

Oh I see, this is specific to iOS and opening the playback session before the server connection.

Milor123 commented 2 months ago

I have the same problem here, Android 14 app, when the server is offline it dont allow save bookmarks 0.9.76-beta apk @advplyr

And this in other phone with A11 keep crashing

Both of my phones use MicroG, dont use google services.