search

advplyr / audiobookshelf-app

Mobile application for Audiobookshelf
https://audiobookshelf.org
GNU General Public License v3.0
1.25k stars 170 forks source link

[Android] Add adaptive app icon & monochromatic app icon #786

Closed woofwoof69 closed 11 months ago

woofwoof69 commented 1 year ago

Abs is is my only non coloured coded icon and its messing with my ocd lol, this would be fantastic little touch some when.

More info https://m2.material.io/design/iconography/product-icons.html

woofwoof69 commented 1 year ago

Also it is my only all lowercase name. Most other capitalize each word e.g. AudioBookShelf

nerdpersonthing commented 1 year ago

I think this might be a matter of preference, and not much of an actual problem. I personally find the current icon of the app visually pleasing, and I don't find the all-lowercase name bothersome at all.

I'm not opposed to the app's name being changed to be capitalized, but if that is done, please, please make it only single-capitalized (i.e. Audiobookshelf, not AudioBookShelf). Camel case is... not visually pleasing at all (imo).

advplyr commented 1 year ago

I did the all lowercase intentionally because I thought it looked the best. I'm open to doing Audiobookshelf but I personally don't like AudioBookShelf.

I'm not sure what you mean by "non coloured coded", can you be more specific?

woofwoof69 commented 1 year ago

I did the all lowercase intentionally because I thought it looked the best. I'm open to doing Audiobookshelf but I personally don't like AudioBookShelf.

I'm not sure what you mean by "non coloured coded", can you be more specific?

These guys explained it better than I can and provides a guild too https://developer.android.com/develop/ui/views/launch/icon_design_adaptive

The lower case name thing isn't a big deal but is strange only in comparison and looks a bit like a typo, since noticing it I can't un-see ya'know. Maybe AudiobookShelf? But in my head its always just read as abs

Keep up the great work

woofwoof69 commented 1 year ago

I think this might be a matter of preference, and not much of an actual problem. I personally find the current icon of the app visually pleasing, and I don't find the all-lowercase name bothersome at all.

I'm not opposed to the app's name being changed to be capitalized, but if that is done, please, please make it only single-capitalized (i.e. Audiobookshelf, not AudioBookShelf). Camel case is... not visually pleasing at all (imo).

I love the icon don't change that, it's only the colours that can be changed if the user enables it, I read some where that bright and colourful displays are one trick that make smart phones so addictive I've since gone with straight black screen (oled screen small battery win he he) and all the icons muted abs is the only one left.

Again the capital thing, its only odd cuz it different from everything else (and looks a bit typoish), the suggestion of AudioBookShelf was mainly cuz I always read and think of it as abs so it made sense to capitalize it that way, yea i get its not the best aesthetics but I do like AudiobookShelf do you like the capital S there? I'm down with only the initial A capitalized too.

advplyr commented 11 months ago

I figured this out. Turned out to be a one line update to the icon XML since the icon foreground was already monochromatic. Also capitalized the app name.

advplyr commented 11 months ago

Added in v0.9.68-beta