search

advplyr / audiobookshelf

Self-hosted audiobook and podcast server
https://audiobookshelf.org
GNU General Public License v3.0
6.38k stars 450 forks source link

[Enhancement]: allow -c:a copy as advanced option? #1818

Closed mayli closed 5 months ago

mayli commented 1 year ago

Describe the feature/enhancement

Most my audiobooks are encoded properly and I don't like to re-encode them, can we add an option to allow -c:a copy?

https://github.com/advplyr/audiobookshelf/blob/8243da69f69b2e4a65aa29acbee1898a89fbff62/server/managers/AbMergeManager.js#L70

advplyr commented 1 year ago

You could use copy here image

Although I'm not sure how ffmpeg will behave if the bitrate and channels are different. I have tested this using copy.

I'm not sure how common mp3 codec is in m4b files

mayli commented 1 year ago

Maybe we could have some UI improvement with a copy checkbox and disable other options.

advplyr commented 5 months ago

I'm merging this with https://github.com/advplyr/audiobookshelf/issues/1257

advplyr commented 5 months ago

Duplicate of https://github.com/advplyr/audiobookshelf/issues/1257

devnoname120 commented 2 weeks ago

I was wondering why converting my AAC files to a M4B audiobook with audiobookshelf would destroy the quality. A combination of reading the source code,git blame, and some clicking around led me to this issue. I agree that it would be nice if discoverability of this feature was improved.