advplyr / audiobookshelf

Self-hosted audiobook and podcast server
https://audiobookshelf.org
GNU General Public License v3.0
6.39k stars 451 forks source link

[Bug]: Cannot clear titles from the "Continue Reading Shelf" #2449

Closed oboe45 closed 9 months ago

oboe45 commented 9 months ago

Describe the issue

There are several titles shown in the Self "Continue Reading" If I Select the option to remove an item from "continue reading", it stays, or it disappears but returns when I restart the app. This is the same issue previously reported in V2.6.0 and reported as fixed in V.2.7.0

Steps to reproduce the issue

  1. Select the option to remove from continue reading
  2. Observer immediate, or later results - items reappear

Audiobookshelf version

V 2.7.0

How are you running audiobookshelf?

Docker

nichwall commented 9 months ago

Are you using the iOS app? Can you Remove Progress on one of the books and then mark the same book as Finished?

oboe45 commented 9 months ago

I use both the web version and the ios APP. Using the IOS App, This workaround worked for the books that had been hanging around for weeks.

The workaround works, but a one step consistent process for the app and the online version makes more sense - why would anyone normally take both steps?

This is still a bug.

On Tue, Dec 26, 2023 at 12:17 PM Nicholas W @.***> wrote:

Are you using the iOS app? Can you Remove Progress on one of the books and then mark the same book as Finished?

— Reply to this email directly, view it on GitHub https://github.com/advplyr/audiobookshelf/issues/2449#issuecomment-1869674220, or unsubscribe https://github.com/notifications/unsubscribe-auth/APZFLTN7577UKHPUPPSMWULYLMBEFAVCNFSM6AAAAABBDM53IKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGY3TIMRSGA . You are receiving this because you authored the thread.Message ID: @.***>

nichwall commented 9 months ago

This is a bug with the iOS app sometimes having duplicate progress percentages for a book and reporting both (one completed, one incomplete). The bug should be fixed, but leftover data in the app may not have been deleted if you encountered it without realizing.

How long have you been using the iOS app?

https://github.com/advplyr/audiobookshelf/issues/1983

oboe45 commented 9 months ago

A couple of years - not sure .

As long as I am able to just clear the shelf of "Continues" in a reliable fashion - its OK.

Are you saying that there is some inconsistency between the APP and the Web version in the way they work for this item? Do they not use the same DB? If there is a difference, I would prefer to make the "continue Reading" shelf optional - prefer not to see it at all than have it requiring some kind of additional manual adjustments

The problem with a great app like this one is that minor issues become a constant itch to keep scratching at even though there is really no point!

On Tue, Dec 26, 2023 at 2:37 PM Nicholas W @.***> wrote:

This is a bug with the iOS app sometimes having duplicate progress percentages for a book and reporting both (one completed, one incomplete). The bug should be fixed, but leftover data in the app may not have been deleted if you encountered it without realizing.

How long have you been using the iOS app?

1983 https://github.com/advplyr/audiobookshelf/issues/1983

— Reply to this email directly, view it on GitHub https://github.com/advplyr/audiobookshelf/issues/2449#issuecomment-1869736431, or unsubscribe https://github.com/notifications/unsubscribe-auth/APZFLTKDSEZUIWJSXN25AZ3YLMRN7AVCNFSM6AAAAABBDM53IKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZG4ZTMNBTGE . You are receiving this because you authored the thread.Message ID: @.***>

nichwall commented 9 months ago

No, the problem was a specific issue with the iOS app related to syncing and local playback (not really clear on all of the details since I don't have any Apple devices), with a few different ways the duplicate playback could come up. The extra sessions are not cleaned up automatically to ensure actual progress isn't accidentally deleted.

If you've been using the app for that long, it is most likely related to either a specific app version you were using that had the bug, or due to a migration issue that went unnoticed when you performed the server SQLite migration beginning in 2.3.x.

It is recommended that you reset your mobile app if you haven't done this since the SQLite migration (only need to do it once since upgrading from 2.2.x). There have been a few edge cases like this due to some checks against the old ID being forgotten (more information in the previously linked issue). In general you don't need to reset the app after server or app updates, but that specific migration caused a lot of headache.

There are already several feature requests for reordering, hiding, and making custom shelves between the server and app repo.

oboe45 commented 9 months ago

What do you mean by "reset the app" - delete it and reload a fresh copy??

On Tue, Dec 26, 2023 at 3:49 PM Nicholas W @.***> wrote:

No, the problem was a specific issue with the iOS app related to syncing and local playback (not really clear on all of the details since I don't have any Apple devices), with a few different ways the duplicate playback could come up. The extra sessions are not cleaned up automatically to ensure actual progress isn't accidentally deleted.

If you've been using the app for that long, it is most likely related to either a specific app version you were using that had the bug, or due to a migration issue that went unnoticed when you performed the server SQLite migration beginning in 2.3.x.

It is recommended that you reset your mobile app if you haven't done this since the SQLite migration (only need to do it once since upgrading from 2.2.x). There have been a few edge cases like this due to some checks against the old ID being forgotten (more information in the previously linked issue). In general you don't need to reset the app after server or app updates, but that specific migration caused a lot of headache.

There are already several feature requests for reordering, hiding, and making custom shelves between the server and app repo.

— Reply to this email directly, view it on GitHub https://github.com/advplyr/audiobookshelf/issues/2449#issuecomment-1869765765, or unsubscribe https://github.com/notifications/unsubscribe-auth/APZFLTLCRS4C2I3JSGKO3RDYLMZ7HAVCNFSM6AAAAABBDM53IKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZG43DKNZWGU . You are receiving this because you authored the thread.Message ID: @.***>

advplyr commented 9 months ago

If you had downloaded the book with server v2.2.24 or below there is a chance that the book created a duplicate record in the database. I mentioned that here https://github.com/advplyr/audiobookshelf/issues/1983#issuecomment-1783864608

It sounds like you did download the books a long time ago and could have hit that bug. If discarding the progress resolved it then it's fine.