Open rakorea opened 4 months ago
Is the /config
folder on a network drive?
Is the
/config
folder on a network drive?
No, everything is local on the server
What seems suspicious about log above is that the same line appears twice in succession within a short timeframe:
2024-02-25 10:29:41.260 DEBUG [PlaybackSessionManager] Inserting new session for "bookname" (2899EE32-E3FB-4B6F-A5A1-00714B601EB6)
2024-02-25 10:29:41.274 DEBUG [PlaybackSessionManager] Inserting new session for "bookname" (2899EE32-E3FB-4B6F-A5A1-00714B601EB6)
It does smell like a race condition...
I also encountered the same issue after connecting to the server
Still the same issue
Describe the issue
When connecting iOS Application v0.9.72-beta to server 2.8.0, server crashes.
Checked that the server code in question does seem to check if session exists, but I still get the following log:
After app restart the connection works fine. Looks like race condition to me, but I'm not a Node dev. Whether this is mobile app misbehaving and somehow throwing 2 concurrent threads to server is beyond me, server crashing here is obviously not ideal.
https://github.com/advplyr/audiobookshelf/blob/d8b9f08e5a00b113e33367e1d4ed5ef593d02b18/server/managers/PlaybackSessionManager.js#L136
Running the server on Qnap NAS, installed via .qpkg package from https://www.myqnap.org/product/audiobookshelf/
Steps to reproduce the issue
Unfortunately have not found bullet proof way to reproduce. Usage pattern is usually:
This results to server crashing almost daily.
Audiobookshelf version
2.8.0
How are you running audiobookshelf?
Other