search

advplyr / audiobookshelf

Self-hosted audiobook and podcast server
https://audiobookshelf.org
GNU General Public License v3.0
6.37k stars 449 forks source link

[Enhancement] Embed "Language" with Embed Metadata tool #2924

Open MarcoMue opened 5 months ago

MarcoMue commented 5 months ago

Describe the issue

When filling out the Language Field and then using Embed Metadata => Quick Embed, no id3 tag for the language is added or filled.

I checked if its there with vlc, windows properties and Mp3Tag. I was working with a m4b file.

Steps to reproduce the issue

  1. Fill the Language Field in the Book Details.
  2. Navigate to Tools.
  3. Use Quick Embed.

Audiobookshelf version

v2.9.0

How are you running audiobookshelf?

Docker

MarcoMue commented 5 months ago

The Audiobook File Management Tools in ABS also show no Language embed.

I was expecting to see it under 'additionalFields' or a Language Field. Or ideally as TLAN: https://id3.org/id3v2.3.0#TLAN

advplyr commented 5 months ago

M4B files don't use ID3 tags. This is one of the difficulties with meta tags. We'll be switching back to using ffmpeg for embedding meta tags so might be further limited on the data we can embed. https://wiki.multimedia.cx/index.php?title=FFmpeg_Metadata