advplyr / audiobookshelf

Self-hosted audiobook and podcast server
https://audiobookshelf.org
GNU General Public License v3.0
5.52k stars 380 forks source link

[Bug]: Title and X in corners of the web screen when editing the book #2985

Closed ZLoth closed 2 weeks ago

ZLoth commented 2 weeks ago

What happened?

One thing that I noticed is that, when editing a book, the title of the book and the X are at the corners of the screen, and nowhere near the edit window. Shouldn't they be closer?

Chrome: image

Firefox: image

Edge: image

What did you expect to happen?

As I'm editing the book, the title should be optional, but the X should be closer to the edit window.

Steps to reproduce the issue

Just edit a book and look at the corners of the browser window.

Audiobookshelf version

2.9.0

How are you running audiobookshelf?

Docker

What OS is your Audiobookshelf server hosted from?

Linux

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Chrome

Logs

No logs.

Additional Notes

No response

advplyr commented 2 weeks ago

Very early version of Abs put the close button in the top right of the modal.

A user was having trouble closing the modal because they were looking in the top right of the screen for a close button. Even though clicking anywhere outside of the modal or pressing the escape key would close the modal, they were expecting the close button in the top right of the screen.

I thought it made sense to move it there because a) it frees up some screen space in the modal and b) it is not necessary to click that button to close the modal.

I'm not sure why this would be reported as a bug?

ZLoth commented 2 weeks ago

I thought it made sense to move it there because a) it frees up some screen space in the modal and b) it is not necessary to click that button to close the modal.

I'm not sure why this would be reported as a bug?

It was unexpected, and I didn't notice it until a few days ago. Previously, I just clicked outside the box to close it without making changes, as I didn't notice a cancel button.