[Bug]: Embed Metadata Not Working At All Anymore

EnduringGuerila commented 1 month ago

What happened?

I was editing the Halo collection of m4b files while on abs v2.9.x, I ran into file permissions issues on a few of them not writing and forgot I had made hardlinks and another program had locked the files. In initial attempt to fix the issue, I updated ABS do 2.10.1 and now I can't embed metadata in any files!

The initial permissions issue just didn't change the existing tags. Now, all existing tags get wiped and no new tags get written

Reading the logs, it says it was successful after taking way longer than it used to

the example below, Epitaph was one of the files that had properly embeded metadata before the update. upon rerunning the embed process, no metadata tags exist now.

What did you expect to happen?

Metadata getting written to m4b

Steps to reproduce the issue

click 'quick embed' or 'start embed' from the file management tools section
suffer

Audiobookshelf version

2.10.1

How are you running audiobookshelf?

Debian/PPA

What OS is your Audiobookshelf server hosted from?

Linux

If the issue is being seen in the UI, what browsers are you seeing the problem on?

None

Logs

2024-06-05 04:04:18.830
INFO
[AudioMetadataManager] Starting metadata embed task Embedding metadata in audiobook "HALO: Epitaph".

2024-06-05 04:06:54.071
INFO
[AudioMetadataManager] Successfully tagged audio file "/mnt/media/Audiobooks/Halo Collection/HALO Book 35 - Epitaph (2024)/HALO 35 - Epitaph (2024) by Kelly Gay.m4b"

Additional Notes

No response

nichwall commented 1 month ago

There has not been any changes to how files are combined or metadata is embedded, so it is probably an issue with the m4b since you said it worked for that book before.

There was an issue with ffmpeg not being included correctly on 2.10.0 with the PPA install method, but that was fixed in 2.10.1

Does embedding work with 2.9.0?

advplyr commented 1 month ago

This should be the same as #3029, specific to the Debian package but I'm not sure why you wouldn't be seeing the error log. Can you check the log for something similar to:

Ffmpeg Err: Output format mp4 is not available

EnduringGuerila commented 1 month ago

The only 'error' listed is a Thumbs.db file I deleted after restarting explorer.exe on my desktop. There are no other errors I can find. Do you want me to upload the full log?

EnduringGuerila commented 1 month ago

here is Epitaph.m4b after attempting to embed new tags:

and here is another file before attempting to embed updated tags:

so again, it's not just failing to do anything, it's wiping what's there. and Epitaph was a file that abs had successfully embeded on 2.9.x and I only reran it on 2.10.1 as a test.

EnduringGuerila commented 1 month ago

2024-06-05 22:27:02.091 DEBUG Set Log Level to DEBUG

2024-06-05 22:27:02.101 DEBUG [ApiCacheManager] Array.afterUpsert: Clearing cache

2024-06-05 22:27:26.453 DEBUG [ApiCacheManager] count: 0 size: 0

2024-06-05 22:27:26.456 DEBUG [ApiCacheManager] Cache miss: {"user":"enduring","url":"/libraries/4b2b587c-9f12-4083-9f46-3278839662d5?include=filterdata"}

2024-06-05 22:27:26.523 DEBUG [ApiCacheManager] count: 1 size: 13244

2024-06-05 22:27:26.539 DEBUG Loaded 2 of 2 items for "Continue Listening/Reading" in 0.01s

2024-06-05 22:27:26.561 DEBUG Loaded 2 of 2 items for "Continue Series" in 0.02s

2024-06-05 22:27:26.581 DEBUG Loaded 10 of 223 items for "Recently Added" in 0.02s

2024-06-05 22:27:26.632 DEBUG Loaded 5 of 28 series for "Recent Series" in 0.05s

2024-06-05 22:27:26.689 DEBUG Loaded 10 of 33 items for "Discover" in 0.06s

2024-06-05 22:27:26.720 DEBUG Loaded 10 of 13 items for "Listen/Read Again" in 0.03s

2024-06-05 22:27:26.727 DEBUG Loaded 10 of 54 authors for "Newest Authors" in 0.01s

2024-06-05 22:27:26.727 DEBUG Loaded 7 personalized shelves in 0.20s

2024-06-05 22:27:26.728 DEBUG [ApiCacheManager] Cache miss: {"user":"enduring","url":"/libraries/4b2b587c-9f12-4083-9f46-3278839662d5/personalized?include=rssfeed,numEpisodesIncomplete"}

2024-06-05 22:27:26.728 DEBUG [ApiCacheManager] Caching with 1800000 ms TTL

2024-06-05 22:27:32.145 DEBUG [ApiCacheManager] count: 2 size: 240620

2024-06-05 22:27:32.145 DEBUG [ApiCacheManager] Cache hit: {"user":"enduring","url":"/libraries/4b2b587c-9f12-4083-9f46-3278839662d5?include=filterdata"}

2024-06-05 22:27:32.167 DEBUG [ApiCacheManager] count: 2 size: 240620

2024-06-05 22:27:32.194 DEBUG [ApiCacheManager] Cache miss: {"user":"enduring","url":"/libraries/4b2b587c-9f12-4083-9f46-3278839662d5/series/874f1e63-5794-4706-8928-d385ab1618fa?include=progress,rssfeed"}

2024-06-05 22:27:32.248 DEBUG [ApiCacheManager] count: 3 size: 242334

2024-06-05 22:27:32.275 DEBUG Loaded 35 of 35 items for libary page in 0.03s

2024-06-05 22:27:32.276 DEBUG [ApiCacheManager] Cache miss: {"user":"enduring","url":"/libraries/4b2b587c-9f12-4083-9f46-3278839662d5/items?filter=series.ODc0ZjFlNjMtNTc5NC00NzA2LTg5MjgtZDM4NWFiMTYxOGZh&limit=100&page=0&minified=1&include=rssfeed,numEpisodesIncomplete"}

2024-06-05 22:27:37.254 INFO [AudioMetadataManager] Starting metadata embed task Embedding metadata in audiobook "HALO: Epitaph".

2024-06-05 22:28:09.689 INFO [AudioMetadataManager] Successfully tagged audio file "/mnt/media/Audiobooks/Halo Collection/HALO Book 35 - Epitaph (2024)/HALO 35 - Epitaph (2024) by Kelly Gay.m4b"

2024-06-05 22:28:09.690 DEBUG [AudioMetadataManager] Task finished and no tasks remain in queue

EnduringGuerila commented 4 weeks ago

So, I downgraded back to 2.9.0 and it didn't start working again. Here is the update log of the other packages that updated at the same time that I originally updated to 2.10.1:

Start-Date: 2024-06-05  00:22:34
Commandline: apt upgrade
Upgrade: 
audiobookshelf:amd64 (2.9.0, 2.10.1), 
libglib2.0-data:amd64 (2.74.6-2, 2.74.6-2+deb12u2), 
less:amd64 (590-2, 590-2.1~deb12u2), 
libc6:amd64 (2.36-9+deb12u4, 2.36-9+deb12u7), 
locales:amd64 (2.36-9+deb12u4, 2.36-9+deb12u7), 
libglib2.0-0:amd64 (2.74.6-2, 2.74.6-2+deb12u2), 
libc-l10n:amd64 (2.36-9+deb12u4, 2.36-9+deb12u7), 
libc-bin:amd64 (2.36-9+deb12u4, 2.36-9+deb12u7)
End-Date: 2024-06-05  00:22:47

advplyr commented 3 weeks ago

I'm not sure what to do here. Is the embed still not working for you?

EnduringGuerila commented 1 week ago

sorry, not getting notifications for some reason. no, the embed is still not working

advplyr / audiobookshelf